Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: failing test #6876

Merged
merged 1 commit into from
Aug 22, 2023
Merged

remove: failing test #6876

merged 1 commit into from
Aug 22, 2023

Conversation

stephenjason89
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 769abca

Refactored the code for opening the shopping cart modal from the navbar. Moved the logic and configuration from ShoppingCartModalConfig.ts and ShoppingCartButton.vue to Navbar.vue to improve code organization and performance.

🤖 Generated by Copilot at 769abca

ShoppingCartButton
Simpler, no more emit -
Autumn leaves falling

@stephenjason89 stephenjason89 requested a review from a team as a code owner August 22, 2023 14:27
@stephenjason89 stephenjason89 requested review from preschian and roiLeo and removed request for a team August 22, 2023 14:27
@kodabot
Copy link
Collaborator

kodabot commented Aug 22, 2023

SUCCESS @stephenjason89 PR for issue #6875 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9360223
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e4c5ba19e8f90008fee744
😎 Deploy Preview https://deploy-preview-6876--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 22, 2023

AI-Generated Summary: This pull request removes a failing unit test file titled 'BasicBalanceInput.test.ts' from the project. This removal affected 75 lines of test cases written for the BalanceInput.vue component of the application. These included tests relating to HTML5 validity checks, setting of proper value from props, and conversion of value based on unit, among others. It appears that these tests were not passing or they were not relevant anymore to the current application's behavior.

@reviewpad reviewpad bot added the small Pull request is small label Aug 22, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 22, 2023

Code Climate has analyzed commit 9360223 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

908

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 22, 2023
@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels Aug 22, 2023
@yangwao
Copy link
Member

yangwao commented Aug 22, 2023

fixed broken test from

@yangwao yangwao merged commit 69d4d6a into kodadot:main Aug 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BasicBalanceInput Test
5 participants