Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sidebar title padding and icon #6867

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

justskinny5
Copy link
Contributor

@justskinny5 justskinny5 commented Aug 22, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
  • sidebars'(notif, connect wallet, profile, cart) padding's vertical to 24px

CleanShot 2023-08-22 at 16 38 06

  • use this xmark - regular, sharp and make it 20px

CleanShot 2023-08-22 at 16 30 52@2x

Copilot Summary

🤖 Generated by Copilot at 9ee51c7

Updated the close icons and header spacing of ConnectWalletModal and ShoppingCartModal to improve consistency and usability. Refactored some common styles and components to avoid duplication.

🤖 Generated by Copilot at 9ee51c7

We are the masters of the modal
We wield the xmark as our blade
We crush the foes of py-5
We rule the realm of modal-card-head

@justskinny5 justskinny5 requested a review from a team as a code owner August 22, 2023 07:44
@justskinny5 justskinny5 requested review from preschian and daiagi and removed request for a team August 22, 2023 07:44
@kodabot
Copy link
Collaborator

kodabot commented Aug 22, 2023

SUCCESS @justskinny5 PR for issue #6535 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 50c589d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e57a510fbc4f00088b88ba
😎 Deploy Preview https://deploy-preview-6867--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 22, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 22, 2023

AI-Generated Summary: This pull request makes stylistic changes to several Vue.js components and a related SCSS file for better appearance. Specifically, the padding in header elements of the ConnectWalletModal.vue, NotificationBoxModal.vue, and ShoppingCartModal.vue files is slightly increased for better whitespace balance. Furthermore, it also modifies the icon used to represent the 'close' action in these same files, changing it from 'close' to 'xmark' for a better aesthetic fit. It also sets the size of these icons to 'medium'. An additional change involves adjusting the padding in the CSS class .modal-card-head in _connect-wallet.scss for better visual balance.

@preschian preschian requested a review from exezbcz August 22, 2023 08:34
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need @exezbcz approval
code lgtm

@exezbcz
Copy link
Member

exezbcz commented Aug 22, 2023

nice job, works for me

@prury
Copy link
Member

prury commented Aug 22, 2023

will check again after request changes gets solved

@codeclimate
Copy link

codeclimate bot commented Aug 23, 2023

Code Climate has analyzed commit 50c589d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@daiagi
Copy link
Contributor

daiagi commented Aug 23, 2023

@prury
code lgtm - please test again

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 23, 2023
@yangwao
Copy link
Member

yangwao commented Aug 24, 2023

pay 30 usd

@yangwao yangwao merged commit 665089d into kodadot:main Aug 24, 2023
@yangwao
Copy link
Member

yangwao commented Aug 24, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.48 USD/DOT ~ 6.696 $DOT
🧗 129QwMHtmhf7qGF5EoMxVT7dosyb9SYZTkJTfQHYQ3kUQap4
🔗 0xa560b64a540a023bcff81431bb9bdd88d1019f5ab6d37966e6cfcf9cf24b1b29

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 24, 2023
This was referenced Aug 24, 2023
This was referenced Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar title padding and xmark
7 participants