Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(BasicNumberInput): to composition api #6830

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

leo-anderson-x
Copy link
Contributor

@leo-anderson-x leo-anderson-x commented Aug 20, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 8c3cecd

Refactored BasicNumberInput.vue to use Vue 3 Composition API. Removed VModel and Prop decorators and replaced them with defineProps, defineEmits, and computed helpers. Improved code readability and TypeScript support.

🤖 Generated by Copilot at 8c3cecd

BasicNumberInput
Composed with new Vue syntax
Spring of refactoring

@netlify
Copy link

netlify bot commented Aug 20, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2a05fdb
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e2dcb8b23ae7000749d9b1
😎 Deploy Preview https://deploy-preview-6830--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 20, 2023

AI-Generated Summary: This pull request refactors the BasicNumberInput.vue component in the shared form components folder. It migrates the script from using the nuxt-property-decorator to the Vue Composition API. It also replaces the component definition and replaces it with the setup method in the script. The props definitions and the emit function are also updated, and the focus state is now managed with the ref function. Furthermore, the default properties expanded, min, and step are set in the props object. Changes are made to make the component more simplified and maintainable.

@reviewpad reviewpad bot added the small Pull request is small label Aug 20, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 20, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@leo-anderson-x leo-anderson-x marked this pull request as ready for review August 20, 2023 11:51
@leo-anderson-x leo-anderson-x requested a review from a team as a code owner August 20, 2023 11:51
@leo-anderson-x leo-anderson-x requested review from roiLeo and vikiival and removed request for a team August 20, 2023 11:51
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Have you tested the componen?

@leo-anderson-x
Copy link
Contributor Author

Have you tested the componen?

@vikiival Yes, I tested Royalty Rate Input:

CleanShot.2023-08-20.at.22.10.51.mp4

@stephenjason89
Copy link
Contributor

code lgtm

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff, otherwise lgtm

components/shared/form/BasicNumberInput.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Aug 21, 2023

Code Climate has analyzed commit 2a05fdb and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.7% 1.7% Duplication

@vikiival vikiival merged commit 3f27a4d into kodadot:main Aug 21, 2023
11 checks passed
@vikiival
Copy link
Member

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.48 USD/DOT ~ 6.696 $DOT
🧗 12RA5J7wGg6bDWPTZG359Pn5bCzXSJRfsifo3UktqVAjhJ9k
🔗 0x39779ecfd9ae4b65b676bae88b3539f3b62cff942594548ab1786110d6357d74

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 21, 2023
@leo-anderson-x leo-anderson-x deleted the 4750-number-input branch August 21, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants