Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 DropUpload vue3 #6790

Merged
merged 5 commits into from
Aug 18, 2023
Merged

🔧 DropUpload vue3 #6790

merged 5 commits into from
Aug 18, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 18, 2023 •
edited
Loading

⚠️ didn't test

🧪 on /snek/gallery/3124270296-9

@roiLeo roiLeo requested a review from a team as a code owner August 18, 2023 13:32
@roiLeo roiLeo requested review from vikiival and Jarsen136 and removed request for a team August 18, 2023 13:32
@netlify
Copy link

netlify bot commented Aug 18, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 73f9e82
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64df7db37cdf6c000859cfee
😎 Deploy Preview https://deploy-preview-6790--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 18, 2023

AI-Generated Summary: This pull request updates the DropUpload.vue component. The update involves refactoring the component to make use of Vue 3's composition API instead of the previous options-based API. This includes redefining props, introducing new composables such as ref and computed, and reconfiguring how functions and lifecycle hooks are utilized. The overall functionality of the component, which presumably supports uploading files, has not been significantly changed. However, the refactored code should now be more aligned with Vue 3's composition API design patterns which enhance readability and reusability in Vue.JS applications.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Aug 18, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 18, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Jarsen136
Jarsen136 reviewed Aug 18, 2023
View reviewed changes
components/shared/DropUpload.vue Outdated Show resolved Hide resolved
components/shared/DropUpload.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Aug 18, 2023

Code Climate has analyzed commit 73f9e82 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury
Copy link
Member

prury commented Aug 18, 2023

https://deploy-preview-6790--koda-canary.netlify.app/bsx/gallery/5347553-1
drag and drop ✔️
image loads ✔️

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 18, 2023
@yangwao yangwao self-requested a review August 18, 2023 14:39
@yangwao yangwao enabled auto-merge August 18, 2023 14:39
@roiLeo roiLeo mentioned this pull request Aug 18, 2023
Closed
@yangwao yangwao merged commit 397c96c into kodadot:main Aug 18, 2023
10 checks passed
vikiival
vikiival approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.-

@roiLeo roiLeo deleted the chore/vue3/DropUpload branch August 18, 2023 15:20
@yangwao yangwao mentioned this pull request Aug 19, 2023
Merged
This was referenced Aug 19, 2023
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@vikiival vikiival vikiival approved these changes

@yangwao yangwao yangwao approved these changes

Assignees
No one assigned
Labels
medium Pull request is medium S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roiLeo @prury @yangwao @vikiival @Jarsen136