Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: token symbol on carousel #6775

Merged
merged 2 commits into from
Aug 18, 2023
Merged

fix: token symbol on carousel #6775

merged 2 commits into from
Aug 18, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Aug 18, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 1635735

Refactored carousel info component to use a more generic money component and simplified currency symbol logic. Removed unused code.

🤖 Generated by Copilot at 1635735

We're sailing on the blockchain, me hearties, yo ho ho
We've got to keep our code clean and tidy, don't you know
We've swapped CommonTokenMoney for Money, that's the way
We've simplified the currency symbol, hip hooray

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 685067f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64df47bc0dafb10007b0ebbc
😎 Deploy Preview https://deploy-preview-6775--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 18, 2023

AI-Generated Summary: This pull request provides a fix for displaying the token symbol in the carousel component. In the file CarouselInfo.vue, the <CommonTokenMoney> component has been replaced by the <Money> component and its usage adjusted to include the unit-symbol attribute. The getTokenId method, which was previously used to fetch the token ID, has been removed and replaced with a unitSymbol computed property that makes use of the prefixToToken utility. This change simplifies the display of Price in the Carousel, making the code more readable, and likely resolving potential symbol mismatches in token display.

@reviewpad reviewpad bot added the small Pull request is small label Aug 18, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 18, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Aug 18, 2023

Code Climate has analyzed commit 685067f and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@preschian preschian marked this pull request as ready for review August 18, 2023 10:29
@preschian preschian requested a review from a team as a code owner August 18, 2023 10:29
@preschian preschian requested review from roiLeo and daiagi and removed request for a team August 18, 2023 10:29
@@ -10,6 +10,7 @@ export const prefixToToken = {
bsx: 'KSM',
snek: 'KSM',
ahk: 'KSM',
ahp: 'DOT',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yangwao
Copy link
Member

yangwao commented Aug 18, 2023

pay 50 usd

@yangwao yangwao merged commit 109b16d into main Aug 18, 2023
11 checks passed
@yangwao yangwao deleted the fix/token-symbol-on-carousel branch August 18, 2023 11:46
@yangwao
Copy link
Member

yangwao commented Aug 18, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.49 USD/DOT ~ 11.136 $DOT
🧗 1xjvRADwdJcnmUCLWerEHR4iGCT5EBTm4D4fzLLg4LcAC9p
🔗 0x03fa73960f9ca338a1e3dd17b44bb502ca7223887b270c0d4d6e4f0618d29529

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants