Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 vue3 composition api #6703

Merged
merged 11 commits into from
Aug 14, 2023
Merged

🔧 vue3 composition api #6703

merged 11 commits into from
Aug 14, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 14, 2023 •
edited
Loading

@roiLeo roiLeo requested a review from a team as a code owner August 14, 2023 10:00
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team August 14, 2023 10:00
@netlify
Copy link

netlify bot commented Aug 14, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d9be03b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64da41b72064e3000877db69
😎 Deploy Preview https://deploy-preview-6703--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 14, 2023

AI-Generated Summary: This pull request includes two significant changes. The first patch updates the EmotionList.vue file in the components/rmrk/Gallery/ directory. It includes changes such as the introduction of the Vue 3 composition API. The second patch updates the History.vue file in the same directory, which also switches to the Vue 3 composition API. Revisions streamline and refactor the code, reducing the total lines of code and improving readability and maintainability.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Aug 14, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 14, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

daiagi
daiagi reviewed Aug 14, 2023
View reviewed changes
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol stuff here and there

components/rmrk/Gallery/History.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/History.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/History.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/Holder/Holder.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/Holder/Holder.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/Holder/Holder.vue Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Aug 14, 2023

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 14, 2023
vikiival
vikiival reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol

components/bsx/Offer/OfferTable.vue
@@ -188,21 +189,9 @@ const tellFrens = (caller: string, withdraw: boolean) => {
}

watch(currentPage, (val) => {
replaceUrl(String(val))
replaceUrl({ page: String(val) })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GIga cHad Enerygy

components/rmrk/Gallery/History.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Aug 14, 2023

Code Climate has analyzed commit d9be03b and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@yangwao yangwao merged commit 3fa9006 into kodadot:main Aug 14, 2023
This was referenced Aug 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival left review comments

@daiagi daiagi daiagi approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
large Pull request is large S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roiLeo @yangwao @vikiival @daiagi @prury