Refactor/decorator2

[stephenjason89]

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Related with Reduce using nuxt-property-decorator and use composition API #4750
• Related with migrate/remove unused mixins #6392
• Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality

Optional

• I've tested it at </ksm/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Did your issue had any of the "$" label on it?

• Fill up your DOT address: Payout

Community participation

• Are you at KodaDot Discord?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 769abca

Refactored the code for opening the shopping cart modal from the navbar. Moved the logic and configuration from ShoppingCartModalConfig.ts and ShoppingCartButton.vue to Navbar.vue to improve code organization and performance.

🤖 Generated by Copilot at 769abca

ShoppingCartButton
Simpler, no more emit -
Autumn leaves falling

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	4904b61
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64dabb187710580008227638
😎 Deploy Preview	https://deploy-preview-6693--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request consists of two patches both refactoring Vue.js components to use the Composition API. The first patch refactors the 'TokenBalanceInput' component, getting rid of the previous usage of mixins, modifying the structure of the script block, and creating a new composable 'useAsset' for shared logic. This new composable includes a 'getAssetById' method, which fetches the asset by its ID from the assets store.

The second patch refactors the 'MultiPaymentFeeButton' component, once again replacing mixins with the Vue.js Composition API. The component's various properties, including 'tokenId', 'asset', 'unit' and 'url', have been rewritten using 'computed' and 'ref' functions. The method 'fetchCurrency' has also been modified and now it is an async function. Observability on 'accountId' is established using the 'watch' function. The 'fetchCurrency' method is called when the 'accountId' changes. Overall, these changes improve readability, maintainability and promote code reusability across the Vue.js application.

[reviewpad]

Reviewpad Report

⚠️ Warnings

• Please link an issue to the pull request

[roiLeo]

Small stuff. otherwise lgtm, tested on /snek

[vikiival]

Nice Job!

[stephenjason89]

Thank you @vikiival & @roiLeo for reviewing my PR.

[roiLeo]

✅ code lgtm

[codeclimate]

Code Climate has analyzed commit 4904b61 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[vikiival]

@prury can I ask for a recheck one more time if validation works?

[yangwao]

@stephenjason89 let's check deepscan

• https://deepscan.io/dashboard/#view=project&tid=13903&pid=16948&bid=372223&subview=pull-request&prid=1696270

[prury]

@prury can I ask for a recheck one more time if validation works?

on it!

[stephenjason89]

@stephenjason89 let's check deepscan

• https://deepscan.io/dashboard/#view=project&tid=13903&pid=16948&bid=372223&subview=pull-request&prid=1696270

Sorry I am not familiar with deepscan very well. Can anyone please explain? I checked components/rmrk/Profile/Sales.vue but i don't know how it is connected with the files in this PR.

Or are these issues completely unrelated and you want me to see and fix? @yangwao
If that's the case, I'll hunt issues with deepscan really nice tool.

[prury]

if it does what i think it does (refactor the part related to bsx assets and its balances and also the button to change asset fee on bsx) then it works 😄

https://basilisk.subscan.io/tx/0xd3a89e8a289a56677972b5c8fe600cead5e68df63c9fe7ad3f2cfdbc11821bdc

[stephenjason89]

if it does what i think it does (refactor the part related to bsx assets and its balances and also the button to change asset fee on bsx) then it works 😄

https://basilisk.subscan.io/tx/0xd3a89e8a289a56677972b5c8fe600cead5e68df63c9fe7ad3f2cfdbc11821bdc

I don't understand the basilik scan btw. I just see a couple of transactions being made. I just recently started on this project so need more help @prury, would greatly appreciate if you can explain in more detail

Thank you

[yangwao]

pay 50 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.78 USD/DOT ~ 10.46 $DOT
🧗 16UcV9V6nVvPYdHz98ymUKmNLkzjCEU5sbKJMi7hxYyTHjzR
🔗 0xe4c12d2e443dc979709e19365f6182ee89fa40501745a12d76d3b815b612c182

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues