Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(error): changed links style to not have the same as default text #6686

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

stephenjason89
Copy link
Contributor

@stephenjason89 stephenjason89 commented Aug 12, 2023

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image

Copilot Summary

🤖 Generated by Copilot at 769abca

Refactored the code for opening the shopping cart modal from the navbar. Moved the logic and configuration from ShoppingCartModalConfig.ts and ShoppingCartButton.vue to Navbar.vue to improve code organization and performance.

🤖 Generated by Copilot at 769abca

ShoppingCartButton
Simpler, no more emit -
Autumn leaves falling

@stephenjason89 stephenjason89 requested a review from a team as a code owner August 12, 2023 08:21
@stephenjason89 stephenjason89 requested review from preschian and vikiival and removed request for a team August 12, 2023 08:21
@kodabot
Copy link
Collaborator

kodabot commented Aug 12, 2023

SUCCESS @stephenjason89 PR for issue #6654 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 12, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 42920af
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64d740f0b8f1bd00088659c7
😎 Deploy Preview https://deploy-preview-6686--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 12, 2023

AI-Generated Summary: This pull request includes a minor improvement to the UI styling in the error.vue file. The change involves modifying the style of the link to make it visually different from the default text. Now the link is underlined and presented in a different color (orange). Additionally, a small typo in the text was corrected.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 12, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 12, 2023

Code Climate has analyzed commit 42920af and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 14, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as quickfix

@vikiival vikiival merged commit 7a8b57d into kodadot:main Aug 14, 2023
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Aug 14, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 5 USD/DOT ~ 2 $DOT
🧗 16UcV9V6nVvPYdHz98ymUKmNLkzjCEU5sbKJMi7hxYyTHjzR
🔗 0x4ddf165c179de01afe5b2032dfa95887770eb3cabe5c4a10dcedf847ca2108ea

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 14, 2023
@exezbcz exezbcz mentioned this pull request Aug 14, 2023
This was referenced Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants