Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init modal migration from buefy to oruga #6612

Closed
wants to merge 3 commits into from
Closed

fix: init modal migration from buefy to oruga #6612

wants to merge 3 commits into from

Conversation

dxphilo
Copy link
Contributor

@dxphilo dxphilo commented Aug 8, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Part of #5852

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Bumped into some errors while configuring Oruga. Still investigating. Might be compatibility issues

Screenshot 2023-08-08 at 13 02 27

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at ae3eed4

This pull request mainly replaces the buefy modal components with the oruga modal components in various files, as part of a UI library refactoring. It also changes some props to use kebab-case instead of camelCase, as suggested by the Vue style guide. Additionally, it reorders some imports to follow the alphabetical order, as suggested by the TypeScript style guide.

🤖 Generated by Copilot at ae3eed4

buefy to oruga
kebab-case for props and imports
a fresh spring cleaning

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit be0c8e3
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64d21296fcdf830007e70936
😎 Deploy Preview https://deploy-preview-6612--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 8, 2023

AI-Generated Summary: This pull request includes several modifications mainly aimed at migrating modal usage from Buefy to Oruga. This is reflected in multiple components including ConnectWallet, ShoppingCart, NotificationBoxButton, and more. The request also includes renaming some parameters in Vue components, changing kebab-case to camel-case. A few changes in the imports order are also made in the test files for better consistency and readability.

@reviewpad reviewpad bot added the small Pull request is small label Aug 8, 2023
@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels Aug 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit be0c8e3 and detected 0 issues on this pull request.

View more on Code Climate.

@dxphilo
Copy link
Contributor Author

dxphilo commented Aug 8, 2023

It appears that these errors might be somehow connected to #6610. Isn't that the case, @roiLeo?

@roiLeo
Copy link
Contributor

roiLeo commented Aug 8, 2023

It appears that these errors might be somehow connected to #6610. Isn't that the case, @roiLeo?

Yes, not possible to use oruga-next with nuxt-bridge (vue2) project. have you tried with oruga instead of oruga-next?

@dxphilo
Copy link
Contributor Author

dxphilo commented Aug 8, 2023

It appears that these errors might be somehow connected to #6610. Isn't that the case, @roiLeo?

Yes, not possible to use oruga-next with nuxt-bridge (vue2) project. have you tried with oruga instead of oruga-next?

Not yet, I can try it out and see what works here.

@roiLeo
Copy link
Contributor

roiLeo commented Aug 8, 2023

Not yet, I can try it out and see what works here.

I don't think this is a good idea we'll still need to upgrade to Vue3 version..

@dxphilo
Copy link
Contributor Author

dxphilo commented Aug 8, 2023

I'll close this for now.

@dxphilo dxphilo closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programmatic Modal
2 participants