Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BlogPost] Dynamic NFTs: Revolutionizing Digital Ownership #6503

Merged
merged 6 commits into from
Aug 1, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jul 31, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

/blog/revolutionizing-digital-ownership

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;

Copilot Summary

🤖 Generated by Copilot at ea281f0

Added a new blog post content/blog/revolutionizing-digital-ownership.md about dynamic NFTs, their features, benefits, and examples. The post aims to inform and engage the website visitors about this innovative technology in the NFT space.

🤖 Generated by Copilot at ea281f0

NFT-gallery
Dynamic art on the blockchain
Autumn of innovation

@hassnian hassnian requested a review from a team as a code owner July 31, 2023 10:33
@hassnian hassnian requested review from roiLeo and daiagi and removed request for a team July 31, 2023 10:33
@kodabot
Copy link
Collaborator

kodabot commented Jul 31, 2023

SUCCESS @hassnian PR for issue #6499 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 12a789b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64c7b3224fb51300088d6e0d
😎 Deploy Preview https://deploy-preview-6503--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 31, 2023

AI-Generated Summary: This pull request contains three patches. The first patch addresses an issue with incorrect balance calculations in various chains within the Teleport.vue component by changing the accessed property from 'balance' to 'nativeBalance'. The second patch introduces a new markdown file named "revolutionizing-digital-ownership.md" in the blog's content, adding information about the concepts and applications of Dynamic NFTs (dNFTs). The third and final patch is a minor adjustment, removing unnecessary spaces in the newly added blog markdown file. It ensures clean, well-formatted content by removing four empty lines and adding a missing newline character at the end of the file.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review docs labels Jul 31, 2023
@hassnian
Copy link
Contributor Author

hassnian commented Jul 31, 2023

@roiLeo @daiagi

can someone provide me the links of the images or give me access to ops-internal ? not sure how to continue

thanks

@roiLeo
Copy link
Contributor

roiLeo commented Jul 31, 2023

First one (cover?)
257070396-c71a77fb-70b4-4348-9fcc-15b213af1b4f

Seconde one
257070438-429bd175-4b33-4727-a286-2d8e673cbc9e

Third
257070453-a115a327-7625-471e-8a27-0e2aa9c746ce

Last
257070557-35ed9427-d711-471b-b15e-8ca2f8f80ff1

@codeclimate
Copy link

codeclimate bot commented Jul 31, 2023

Code Climate has analyzed commit 12a789b and detected 0 issues on this pull request.

View more on Code Climate.

@prury
Copy link
Member

prury commented Jul 31, 2023

Spacing:
image

@exezbcz what size or formatting those sub-titles should be/have?
image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 31, 2023
@hassnian
Copy link
Contributor Author

hassnian commented Aug 1, 2023

@prury the spacing issue between articles is already taking care of on this pr https://github.com/kodadot/nft-gallery/pull/6500/files , that's why I didn't change anything here

CleanShot 2023-08-01 at 10 08 05@2x

and with that change the spacing looks like this

CleanShot 2023-08-01 at 10 09 16@2x

if you still want I can make the changes on this pr

@prury
Copy link
Member

prury commented Aug 1, 2023

and with that change the spacing looks like this
CleanShot 2023-08-01 at 10 09 16@2x

if you still want I can make the changes on this pr

oh, thanks for the feedback, yup you are right, no need for changes on the blog structure in this PR, lets stick to the article itself like you said, too many related PRs aswell.

let's just see what @exezbcz says about the titles and we are good to go

@exezbcz
Copy link
Member

exezbcz commented Aug 1, 2023

image

  • this does not look right. Could you please match the style of the card to the card underneath
  • mainly the height and width of the image

@prury
Copy link
Member

prury commented Aug 1, 2023

image

* this does not look right. Could you please match the style of the card to the card underneath

* mainly the height and width of the image

we discussed this above, Hassnian only made changes to the article itself, changes related to how the images behave and spacing will have to be handled in a PR that tackles the blog structure, lmk about the titles tho

and #6505 may have fixed it, but we have to merge first to see

@exezbcz
Copy link
Member

exezbcz commented Aug 1, 2023

@prury yup, the article itself is okay.

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Aug 1, 2023
@yangwao
Copy link
Member

yangwao commented Aug 1, 2023

pay 50 usd

@yangwao yangwao merged commit c789eed into kodadot:main Aug 1, 2023
@yangwao
Copy link
Member

yangwao commented Aug 1, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 5.11 USD/DOT ~ 9.785 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x66559df7c08651744351de39d30b85c38822b6cbe5902cbc13cc12908d64e9c8

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 1, 2023
@hassnian hassnian deleted the issue-6499 branch August 6, 2023 12:19
This was referenced Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BlogPost] Dynamic NFTs: Revolutionizing Digital Ownership
6 participants