Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: General onboarding article for developers want to use KodaDot #6471

Merged
merged 9 commits into from
Aug 1, 2023
Merged

feat: General onboarding article for developers want to use KodaDot #6471

merged 9 commits into from
Aug 1, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jul 25, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

image

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at 0889359

This pull request adds a new blog post to help new contributors get started with KodaDot development, and improves the blog index page layout and functionality. It modifies pages/blog/index.vue to fix some UI issues, and creates content/blog/first-time.md with the new post content.

🤖 Generated by Copilot at 0889359

Sing, O Muse, of the valiant KodaDot contributors
Who, eager to join the NFT revolution, content added
A guide for the novices, full of wisdom and skill
How to set up, run, test, and transact with GraphQL and RPC

@Jarsen136 Jarsen136 requested a review from a team as a code owner July 25, 2023 16:02
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team July 25, 2023 16:02
@kodabot
Copy link
Collaborator

kodabot commented Jul 25, 2023

SUCCESS @Jarsen136 PR for issue #6462 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d77af05
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64c90ec14b99430008ca84f2
😎 Deploy Preview https://deploy-preview-6471--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 25, 2023

AI-Generated Summary: This pull request includes the addition of a new onboarding article for developers looking to use KodaDot. It provides a comprehensive guide to setting up a local environment, starting a dev server, running a local Polkadot and subquery nodes, and frequently asked developer questions. In addition, there are minor adjustments to the blog index file to better the content list format and add the filename into links.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jul 25, 2023
@reviewpad reviewpad bot added small Pull request is small and removed medium Pull request is medium labels Jul 25, 2023
@prury
Copy link
Member

prury commented Jul 25, 2023

i think it needs more spaces between topics:

image

font use should follow a magnitude order big -> small -> smaller or at least be the same:
image

bold?
image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 25, 2023
@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels Jul 26, 2023
@prury
Copy link
Member

prury commented Jul 26, 2023

@Jarsen136 sorry for the trouble, but I've made some in-browser modifications examples to show what i did to improve readability:
image
image

basically what i did: spaces between steps and code squares, spaces between h2 titles sections, reduced the links boldness. Capital letters, some text rearrangement for better user understanding.

@Jarsen136
Copy link
Contributor Author

@Jarsen136 sorry for the trouble, but I've made some in-browser modifications examples to show what i did to improve readability: image image

basically what i did: spaces between steps and code squares, spaces between h2 titles sections, reduced the links boldness. Capital letters, some text rearrangement for better user understanding.

Thanks. I have updated it accordingly. Look like you are really good at writing and article format 😄

@prury
Copy link
Member

prury commented Jul 27, 2023

Thanks. I have updated it accordingly. Look like you are really good at writing and article format 😄

thank you so much, yes, i had my share of text reviewing in a distant past 😄.

it is looking really good now, just one last thing and we are good to go (space before MISC):
image

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jul 27, 2023
@exezbcz
Copy link
Member

exezbcz commented Jul 27, 2023

helo

I would lower the line height here (h1)
image

  • in the Figma its 56px

In case of dark mode, I think we can make the heading true white, with paragraph text staying the same.
image

@Jarsen136
Copy link
Contributor Author

✅ Update

it is looking really good now, just one last thing and we are good to go (space before MISC):

image

I would lower the line height here (h1)
in the Figma its 56px
In case of dark mode, I think we can make the heading true white, with paragraph text staying the same.

image

@exezbcz
Copy link
Member

exezbcz commented Jul 29, 2023

one last thing sir, can we make the code blocks for dark mode too?
image

@Jarsen136 Jarsen136 mentioned this pull request Jul 29, 2023
Closed
@Jarsen136
Copy link
Contributor Author

one last thing sir, can we make the code blocks for dark mode too?

Here is it. #6487

daiagi
daiagi approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 31, 2023
vikiival
vikiival requested changes Jul 31, 2023
View reviewed changes
content/blog/first-time.md Outdated Show resolved Hide resolved
content/blog/first-time.md Outdated Show resolved Hide resolved
pages/blog/index.vue Outdated Show resolved Hide resolved
styles/abstracts/_theme.scss Show resolved Hide resolved
@Jarsen136 Jarsen136 requested a review from vikiival July 31, 2023 16:29
@codeclimate
Copy link

codeclimate bot commented Aug 1, 2023

Code Climate has analyzed commit d77af05 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit d329561 into kodadot:main Aug 1, 2023
@vikiival
Copy link
Member

vikiival commented Aug 1, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Aug 1, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5.09 USD/DOT ~ 3.929 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xc32ed363aecebe6b740b4a6e81043a06adcd50f64736e475cbde478f9eb69976

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 1, 2023
This was referenced Aug 2, 2023
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exezbcz exezbcz exezbcz left review comments

@daiagi daiagi daiagi approved these changes

@vikiival vikiival vikiival approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
medium Pull request is medium paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

General onboarding article for developers want to use KodaDot
7 participants
@Jarsen136 @kodabot @prury @exezbcz @vikiival @yangwao @daiagi