Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 remove tabs from massmint #6459

Merged
merged 3 commits into from
Jul 28, 2023
Merged

🔥 remove tabs from massmint #6459

merged 3 commits into from
Jul 28, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Jul 23, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at 5ea8887

Refactored the Mass Mint feature to have its own route and page. Cleaned up unused and redundant code in Massmint.vue.

🤖 Generated by Copilot at 5ea8887

Sing, O Muse, of the code review that sparked a great debate
Among the developers of the app that mints NFTs with ease
How one of them, a skillful coder, wise and diligent,
Removed the unused tabs that cluttered Massmint.vue with grace

@daiagi daiagi requested a review from a team as a code owner July 23, 2023 02:53
@daiagi daiagi requested review from roiLeo and Jarsen136 and removed request for a team July 23, 2023 02:53
@daiagi daiagi enabled auto-merge July 23, 2023 02:53
@netlify
Copy link

netlify bot commented Jul 23, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1e7af9a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64c0e94b8d29dc00084ad5b8
😎 Deploy Preview https://deploy-preview-6459--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jul 23, 2023

SUCCESS @daiagi PR for issue #6455 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 23, 2023

AI-Generated Summary: This pull request involves a code refactoring where tabs have been removed from the Massmint.vue component in the massmint module. It includes the deletion of a flex div that contained the TabItem component and removal of tabs-related code. This simplifies the component code and may affect the user interface within this application component.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 23, 2023
@Jarsen136
Copy link
Contributor

before
image

after
image

I'm not sure if we should keep only the "Mass mint" tab or make other tabs disabled status.

@daiagi
Copy link
Contributor Author

daiagi commented Jul 23, 2023

@Jarsen136
I remember seeing somewhere discussion with @exezbcz
about removing these tabs and unifying the mass mint page with a new design flow of mint

these tabs are left over from old design and are no longer needed
@exezbcz is that correct?

@exezbcz
Copy link
Member

exezbcz commented Jul 23, 2023

@daiagi yes, that is correct
more info here:

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 23, 2023
@prury
Copy link
Member

prury commented Jul 23, 2023

@daiagi can you make it look like that?

image

as requested inside the figma file:

image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 23, 2023
@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels Jul 26, 2023
@daiagi
Copy link
Contributor Author

daiagi commented Jul 26, 2023

@prury done

@codeclimate
Copy link

codeclimate bot commented Jul 26, 2023

Code Climate has analyzed commit 1e7af9a and detected 0 issues on this pull request.

View more on Code Climate.

@prury
Copy link
Member

prury commented Jul 26, 2023

@prury done

perfect, thank you!

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jul 26, 2023
@yangwao yangwao disabled auto-merge July 28, 2023 16:57
@yangwao yangwao merged commit e662c4c into main Jul 28, 2023
@yangwao yangwao deleted the massmint/remove-tabs branch July 28, 2023 16:57
This was referenced Aug 2, 2023
Merged
Merged
Merged
Merged
Merged
@exezbcz exezbcz mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@roiLeo roiLeo Awaiting requested review from roiLeo roiLeo is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Massmint tabs are not working
6 participants
@daiagi @kodabot @Jarsen136 @exezbcz @prury @yangwao