-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: collectionId in path of url #6454
Conversation
SUCCESS @Jarsen136 PR for issue #6278 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request addresses the issue of how the collectionId is handled in the path of URLs. Four files have been modified and one new file ( |
Code Climate has analyzed commit 995c3c9 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Fixed. I have removed the annoying warning. TBH, this warning is related to other issues instead of the collection search. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODE LGTM
@prury please check if it works as intended
yup, no more warnings and redundancy |
pay 15 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 1f57248
This pull request refactors the collection search feature to use a pinia store and a composable function. This simplifies the code and makes the collection search mode accessible to other components. It also adds a feature to disable the collection search mode on mobile devices.
🤖 Generated by Copilot at 1f57248