Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused mixins #6405

Merged
merged 3 commits into from
Jul 6, 2023
Merged

refactor: remove unused mixins #6405

merged 3 commits into from
Jul 6, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Jul 6, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • seems like this mixins are unused

Copilot Summary

🤖 Generated by Copilot at f46e8bf

Removed unused or obsolete mixins from utils/mixins folder. Simplified and refactored code that depended on these mixins.

🤖 Generated by Copilot at f46e8bf

is_valid checks
refactored for clarity
autumn leaves falling

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8e878ad
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64a6747b675bca0008ba6d8c
😎 Deploy Preview https://deploy-preview-6405--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 6, 2023

AI-Generated Summary: This pull request includes a refactoring process, specifically the removal of unused mixins. The changes impact five files: createdAtMixin.ts, extrinsicsMixin.ts, passionListMixin.ts, queryMixin.ts, and singleSubscribeMixin.ts from the utils/mixins directory. The deletion of these files significantly reduces code clutter by removing a large quantity of unused code (291 lines), leading to speeding up code execution and reducing the possibility of bugs.

@reviewpad reviewpad bot added the medium Pull request is medium label Jul 6, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 6, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@preschian preschian marked this pull request as ready for review July 6, 2023 07:15
@preschian preschian requested a review from a team as a code owner July 6, 2023 07:15
@preschian preschian requested review from vikiival and daiagi and removed request for a team July 6, 2023 07:15
@preschian preschian requested a review from roiLeo July 6, 2023 07:15
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm, none are used

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 6, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 6, 2023

Code Climate has analyzed commit 8e878ad and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit 8c85f19 into main Jul 6, 2023
@roiLeo roiLeo deleted the refactor/unused-mixins branch July 6, 2023 08:03
This was referenced Jul 17, 2023
This was referenced Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants