-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 basicImage responsive to src props changes #6402
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request includes changes to the BasicImage.vue component in the shared/view directory. It introduces a new |
Code Climate has analyzed commit 05f3404 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't this work better with const imageSrc = computed(() => props.src)
?
otherwise code lgtm ✅
I avoided that as it would require a let innerImageSrc = props.src
const loaded = ref(false)
const imageSrc = computed({
get: () => innerImageSrc,
set: (newValue: string) => {
innerImageSrc = newValue
},
})
const onImageLoad = () => {
loaded.value = true
}
const onImageError = (ev: Event) => {
$consola.error('[BasicImage] to load:', props.src, ev)
imageSrc.value = placeholder.value
} |
pay 15 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Test
https://deploy-preview-6402--koda-canary.netlify.app/stmn/collection/u-2024?collectionId=u-2024
Hover over the identity link, images will show
Did your issue had any of the "$" label on it?
Yes, $
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 05f3404
Added a
watchEffect
function toBasicImage.vue
to handle dynamic image source changes. This improves the image component's compatibility with IPFS and blockchain data.🤖 Generated by Copilot at 05f3404