Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Can't change chain from profile page #11193

Merged
merged 8 commits into from
Dec 10, 2024
Merged

fix: Can't change chain from profile page #11193

merged 8 commits into from
Dec 10, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Nov 28, 2024 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

remove once we have multi-vm profiles working

changing prefix from chain selector

  • fix: going from EVM to SUB or the other way will redirect to /

changing prefix from wallet connect

  • fix: connecting a new wallet not prefix change, no redirect (still the same)

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-12-06.at.15.00.05.mp4

@hassnian hassnian requested a review from a team as a code owner November 28, 2024 07:03
@hassnian hassnian requested review from preschian and vikiival and removed request for a team November 28, 2024 07:03
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ce72171
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67580683b8cf610008ae5c7b
😎 Deploy Preview https://deploy-preview-11193--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian marked this pull request as draft November 28, 2024 07:11
@hassnian hassnian requested review from Jarsen136 and removed request for vikiival December 6, 2024 07:30
@hassnian hassnian marked this pull request as ready for review December 6, 2024 10:03
@hassnian hassnian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vikiival vikiival added this pull request to the merge queue Dec 10, 2024
Merged via the queue into kodadot:main with commit 44bf46c Dec 10, 2024
23 of 24 checks passed
This was referenced Dec 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't change chain from profile page
4 participants
@hassnian @preschian @Jarsen136 @vikiival