Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keyup event on Ctrl, Alt, Shift shouldn't emit 'change' event #55

Merged
merged 1 commit into from
Feb 10, 2020
Merged

fix: keyup event on Ctrl, Alt, Shift shouldn't emit 'change' event #55

merged 1 commit into from
Feb 10, 2020

Conversation

jefrydco
Copy link
Contributor

Fix #40

@jefrydco jefrydco requested a review from koca February 10, 2020 01:03
@koca
Copy link
Owner

koca commented Feb 10, 2020

Hey Jefry, Thanks a lot for the PR. i'll merge this one and the other PR ASAP(evening).

@koca koca merged commit 4de0280 into koca:master Feb 10, 2020
@koca
Copy link
Owner

koca commented Feb 10, 2020

Merged! will publish 0.4.0 this evening.

@jefrydco jefrydco deleted the fix/forbidden-key branch February 10, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koca koca koca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Press on keys like Ctrl, Alt, Shift must NOT emit 'change' event.
2 participants
@jefrydco @koca