Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(projectHistoryLogs): fetch filter options from backend TASK-1403 #5401

Merged

Conversation

pauloamorimbr
Copy link
Contributor

@pauloamorimbr pauloamorimbr commented Dec 26, 2024

📣 Summary

The filter options for activity logs now only display the existing options for the project

📖 Description

  • Instead of using a hardcoded list of actions to display the filter data, now we're fetching the available action list from the API.
  • The returned actions are still translated and sorted in the frontend

👀 Preview steps

  1. ℹ️ have account and a project
  2. ℹ️ have activity to be logged in the project
  3. navigate to project settings > activities
  4. 🟢 notice that in the filter selection box only the existing-in-project activity actions are available for filtering

Copy link
Member

@magicznyleszek magicznyleszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just few code style comments and will be good to go 👍

jsapp/js/components/activity/activityLogs.query.ts Outdated Show resolved Hide resolved
jsapp/js/components/activity/activityLogs.query.ts Outdated Show resolved Hide resolved
jsapp/js/components/activity/formActivity.tsx Outdated Show resolved Hide resolved
@pauloamorimbr pauloamorimbr merged commit ead1858 into main Dec 30, 2024
7 checks passed
@pauloamorimbr pauloamorimbr deleted the pamorim/task-1403-fetch-filter-options-from-backend branch December 30, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants