Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form deployment): fix failing to deploy after initial failure #5398

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

duvld
Copy link
Member

@duvld duvld commented Dec 24, 2024

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Fixes an issue where a form will not deploy if it fails one time already.

📖 Description

Connecting to openrosa needed to be wrapped in an atomic transaction.

👀 Preview steps

Feature/no-change template:

  1. ℹ️ have account and a new project
  2. make the project fail to deploy (add 1/0 inside connect() in openrosa_backend.py
  3. deploy the form (it fails)
  4. remove the 1/0
  5. deploy form again (should deploy normally)

See https://www.notion.so/kobotoolbox/Library-locked-form-cannot-be-deployed-1527e515f654806ab4f9c4d42a59ac52

Copy link

Copy link

@JacquelineMorrissette JacquelineMorrissette merged commit 88c17bd into release/2.024.36 Dec 26, 2024
6 checks passed
@JacquelineMorrissette JacquelineMorrissette deleted the 1333-transaction-atomic-fix branch December 26, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants