Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(organizations): remove mmos feature flag TASK-1397 #5392

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

pauloamorimbr
Copy link
Contributor

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Now the Organizations feature implemented up to this point is no longer hidden behind a feature flag

📖 Description

  • isMMosEnabled feature flag was removed
  • routes and menus hidden behind it are now enabled by default
  • organizationQuery no longer returns fixed result for is_mmo

👀 Preview steps

Feature/no-change template:

  1. ℹ️ have account
  2. ℹ️ have or be part of an organization
  3. ℹ️ Make sure to disable the active feature flag with ?ff_isMMosEnabled=false or cleaning your session storage
  4. Navigate to account settings
  5. 🟢 notice that the organization links are visible
  6. 🟢 notice that you can navigate and operate organization feature freely without the feature flag

@@ -95,25 +93,12 @@ export const useOrganizationQuery = (params?: OrganizationQueryParams) => {

// Using a separated function to fetch the organization data to prevent
// feature flag dependencies from being added to the hook
const fetchOrganization = async (): Promise<Organization> => {
const fetchOrganization = async (): Promise<Organization> =>
// `organizationUrl` is a full url with protocol and domain name, so we're
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a style issue: I tend to think we should move all the doc text for fetchOrganization above it. It's essentially a single line of code broken for screen length purposes. Seeing that solo await without brackets around it feels weird.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, combining both comments... Revisiting the existing comment above fetchOrganization, seems if we're removing the feature flag, we can simplify it even more by putting fetchGet<...> into queryFn below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you...nice catch. I visually ignored those comments and should've just removed everything at once. Just did it now. Also some changes to the query were required due to dependencies, since now we're using the organizationUrl inside of the query.

Copy link
Contributor

@jamesrkiger jamesrkiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one minor comment on style, lgtm otherwise

@pauloamorimbr pauloamorimbr merged commit 01789ba into main Dec 23, 2024
7 checks passed
@pauloamorimbr pauloamorimbr deleted the pamorim/task-1397-remove-mmo-feature-flag branch December 23, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants