Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model for per-user-settings #2285

Merged
merged 1 commit into from
May 30, 2019
Merged

Add model for per-user-settings #2285

merged 1 commit into from
May 30, 2019

Conversation

jnm
Copy link
Member

@jnm jnm commented May 29, 2019

allowing us to selectively enable Intercom. Closes #1804. Note that existing INTERCOM_APP_IDs must be migrated from

INTERCOM_APP_ID = os.environ.get('INTERCOM_APP_ID')

to hub.models.PerUserSetting (available in the Django admin interface).

Post-merge

The following PRs must accompany this one:

Checklist

  1. If you've added code that should be tested, add tests
  2. [ ] If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure your code lints and you followed our coding style
  5. [ ] If this is a big feature, make sure to prefix the title with Feature: and add a thorough description for non-dev folk

@jnm jnm force-pushed the 1804-per-user-settings branch from 7f71915 to 03f49b8 Compare May 29, 2019 19:20
allowing us to selectively enable Intercom. Closes #1804
@jnm jnm force-pushed the 1804-per-user-settings branch from 03f49b8 to 8e33563 Compare May 29, 2019 19:55
@jnm jnm merged commit f466a97 into master May 30, 2019
@jnm jnm deleted the 1804-per-user-settings branch May 30, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load intercom only if necessary
1 participant