Skip to content

Commit

Permalink
feat(projectHistoryLogs): remove activity logs feature flag TASK-1385 (
Browse files Browse the repository at this point in the history
…#5364)

### 🗒️ Checklist

1. [x] run linter locally
2. [x] update all related docs (API, README, inline, etc.), if any
3. [x] draft PR with a title `<type>(<scope>)<!>: <title> TASK-1234`
4. [x] tag PR: at least `frontend` or `backend` unless it's global
5. [x] fill in the template below and delete template comments
6. [x] review thyself: read the diff and repro the preview as written
7. [x] open PR & confirm that CI passes
8. [x] request reviewers, if needed
9. [ ] delete this section before merging

### 📣 Summary
Activity logs is no longer hidden behind a feature flag and i snow
accessible via Project > Settings > Activity


### 📖 Description
- The feature flag was removed from the enum
- The link to the route is now always visible

### 👀 Preview steps
1. ℹ️ have an account and a project
2. Remove or disable the activity logs feature flag on with:
`?ff_activityLogsEnabled=false` if needed
4. Navigate to Project > Settings
5. 🟢 The `Activity` session should be accessible
  • Loading branch information
pauloamorimbr authored Dec 19, 2024
1 parent b6a2829 commit 3306623
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
3 changes: 0 additions & 3 deletions jsapp/js/components/formViewSideTabs.es6
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ class FormViewSideTabs extends Reflux.Component {
renderFormSideTabs() {
var sideTabs = [];

const isActivityLogsEnabled = checkFeatureFlag(FeatureFlag.activityLogsEnabled);

if (
this.state.asset &&
this.state.asset.has_deployment &&
Expand Down Expand Up @@ -167,7 +165,6 @@ class FormViewSideTabs extends Reflux.Component {
}

if (
isActivityLogsEnabled &&
userCan(
PERMISSIONS_CODENAMES.manage_asset,
this.state.asset
Expand Down
1 change: 0 additions & 1 deletion jsapp/js/featureFlags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
* For our sanity, use camel case and match key with value.
*/
export enum FeatureFlag {
activityLogsEnabled = 'activityLogsEnabled',
mmosEnabled = 'mmosEnabled',
oneTimeAddonsEnabled = 'oneTimeAddonsEnabled',
exportActivityLogsEnabled = 'exportActivityLogsEnabled',
Expand Down

0 comments on commit 3306623

Please sign in to comment.