Fix linter errors

kobotoolbox · Sep 18, 2024 · 1098de0 · 1098de0
1 parent 7d4edb0
commit 1098de0
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 9 deletions.
diff --git a/kobo/apps/subsequences/actions/keyword_search.py b/kobo/apps/subsequences/actions/keyword_search.py
@@ -69,7 +69,7 @@ def check_submission_status(self, submission):
                 response = self._traverse_object(submission, source)
             except KeyError:
                 continue
-            # FIXME QPATH
+
             xpath = source.split('/')[0]
             all_output = submission[xpath].setdefault(self.ID, [])
             this_output = self._get_matching_element(all_output, **query)
@@ -92,7 +92,7 @@ def run_change(self, submission):
             matches = 0
             for keyword in query['keywords']:
                 matches += response['value'].count(keyword)
-            # FIXME QPATH
+
             xpath = source.split('/')[0]
             all_output = submission[xpath].setdefault(self.ID, [])
             this_output = self._get_matching_element(all_output, **query)

diff --git a/kobo/apps/subsequences/utils/__init__.py b/kobo/apps/subsequences/utils/__init__.py
@@ -160,7 +160,6 @@ def stream_with_extras(submission_stream, asset):
             uuid = submission['_uuid']
 
         all_supplemental_details = deepcopy(extras.get(uuid, {}))
-        # FIXME QPATH
         for supplemental_details in all_supplemental_details.values():
             try:
                 all_qual_responses = supplemental_details['qual']

diff --git a/kobo/apps/subsequences/utils/parse_known_cols.py b/kobo/apps/subsequences/utils/parse_known_cols.py
@@ -16,16 +16,13 @@
 def extend_col_deets(lang: str, coltype: str, label: str, xpath: str) -> dict:
     # NB: refer to commit d013bfe0f5 when trying to figure out the original
     # intent here
-    name = xpath.split('/')[-1]
     out = {
-        'label': name,
         'dtpath': f'{xpath}/{coltype}_{lang}',
         'type': coltype,
         'language': lang,
         'label': f'{label} - {coltype}',
         'name': f'{xpath}/{coltype}_{lang}',
         'source': xpath,
-        # FIXME QPATH
         'xpath': f'{xpath}/{coltype}/{lang}',
         'settings': {'mode': 'manual', 'engine': f'engines/{coltype}_manual'},
         'path': [xpath, coltype],

diff --git a/kpi/models/asset.py b/kpi/models/asset.py
@@ -86,6 +86,7 @@
 from kpi.utils.object_permission import get_cached_code_names
 from kpi.utils.sluggify import sluggify_label
 
+
 class AssetDeploymentStatus(models.TextChoices):
 
     ARCHIVED = 'archived', 'Archived'

diff --git a/kpi/serializers/v2/asset.py b/kpi/serializers/v2/asset.py
@@ -689,9 +689,6 @@ def get_permissions(self, obj):
             queryset.all(), many=True, read_only=True, context=context
         ).data
 
-    def get_project_ownership(self, asset) -> Optional[dict]:
-        pass
-
     def get_project_ownership(self, asset) -> Optional[dict]:
         if not (transfer := asset.transfers.order_by('-date_created').first()):
             return