Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

asterisk and comment icon location in Grid as in KoBo theme #727

Closed
MartijnR opened this issue Apr 26, 2017 · 5 comments
Closed

asterisk and comment icon location in Grid as in KoBo theme #727

MartijnR opened this issue Apr 26, 2017 · 5 comments
Labels

Comments

@MartijnR
Copy link
Member

No description provided.

@MartijnR MartijnR added this to the OpenClinica Next milestone Apr 26, 2017
@MartijnR
Copy link
Member Author

MartijnR commented Apr 26, 2017

Or actually try putting both behind the label to see how that looks (that will probably look better).

@MartijnR
Copy link
Member Author

MartijnR commented Aug 8, 2017

screen shot 2017-08-08 at 3 09 13 pm

@MartijnR
Copy link
Member Author

MartijnR commented Aug 8, 2017

  • make sure asterisk in same location for question with radiobuttons/checkboxes in enketo-core
  • move comment icon slightly to right (or left in RTL) in enketo-core
  • reduce label width to not overlap with comment icon in enketo-core
  • check if comment icon can be shown inline just after label (like in KoBo theme) - NOT EASILY
  • test RTL in enketo-core
  • fix dn icon in EE-oc (similar to comment icon in EE)

@MartijnR
Copy link
Member Author

To display the comment icons inline with the labels, we need to either add HTML markup or remove display: flex in .question. The former is a pretty big deal and the latter will cause problems pushing error messages to the bottom of the cells (see below) and probably other issues.

screen shot 2017-08-10 at 10 23 39 am

@MartijnR
Copy link
Member Author

currently merged fixes already resolve the overlap issue, and make locations consistent between question types. Just need to still slightly tweak the location of the dn icon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant