Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use optionTextValue in filtering #436

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Use optionTextValue in filtering #436

merged 1 commit into from
Jun 29, 2024

Conversation

Brendonovich
Copy link
Contributor

From the Combobox docs:

optionTextValue: The property name to use as the text value of an option for filtering and keyboard navigation.

Currently optionLabel is used for filtering instead of optionTextValue. This PR changes filterFn to use optionTextValue for filtering.

@netlify Netlify
Copy link

netlify bot commented Jun 26, 2024

👷 Deploy request for kobalte pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d57f892

@jer3m01
Copy link
Member

jer3m01 commented Jun 29, 2024

Sweet thanks!

@jer3m01 jer3m01 merged commit 35f3988 into kobaltedev:main Jun 29, 2024
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
Merged
@Genio40921 Genio40921 mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brendonovich @jer3m01