Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform props type API #64

Closed
fabien-ml opened this issue Jan 19, 2023 · 1 comment · Fixed by #68
Closed

Uniform props type API #64

fabien-ml opened this issue Jan 19, 2023 · 1 comment · Fixed by #68

Comments

@fabien-ml
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Some interfaces use isDisabled?: MaybeAccessor<boolean | undefined> while others use isDisabled?: boolean. The former is forcing me to create a function that handles the possible accessor when I need to access the prop myself. Would be nice to standardize on either pattern. Having both is a bit confusing.

Describe the solution you'd like
Remove MaybeAccessor from user facing props type.
@fabien-ml fabien-ml added the WIP Work in progress label Jan 19, 2023
fabien-ml added a commit that referenced this issue Jan 19, 2023
@fabien-ml
Merge pull request #65 from fabien-ml/feat/#64
2b1a6e0 
feat: #64
@github-actions github-actions bot mentioned this issue Jan 19, 2023
Merged
@fabien-ml
Copy link
Collaborator Author

fixed in v0.4.0.

@fabien-ml fabien-ml removed the WIP Work in progress label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update versions kobaltedev/kobalte
1 participant
@fabien-ml