Skip to content

Commit

Permalink
x86: Fix idle consolidation fallout
Browse files Browse the repository at this point in the history
The core code expects the arch idle code to return with interrupts
enabled. The conversion missed two x86 cases which fail to do that.

Reported-and-tested-by: Markus Trippelsdorf <[email protected]>
Tested-by: Borislav Petkov <[email protected]>
Link: http://lkml.kernel.org/r/alpine.LFD.2.02.1305021557030.3972@ionos
Signed-off-by: Thomas Gleixner <[email protected]>
  • Loading branch information
KAGA-KOKO committed May 7, 2013
1 parent 78d77df commit 97a5b81
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions arch/x86/kernel/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,8 @@ void arch_cpu_idle(void)
{
if (cpuidle_idle_call())
x86_idle();
else
local_irq_enable();
}

/*
Expand Down Expand Up @@ -368,9 +370,6 @@ void amd_e400_remove_cpu(int cpu)
*/
static void amd_e400_idle(void)
{
if (need_resched())
return;

if (!amd_e400_c1e_detected) {
u32 lo, hi;

Expand Down

0 comments on commit 97a5b81

Please sign in to comment.