-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Update path-to-regex to v8.1.0 #189
Conversation
is it possible to release v13 also to npmjs with this PR? {
"dependencies": {
"koa-router": "koajs/router"
}
} although I like more {
"dependencies": {
"koa-router": "^13.0.0"
}
} :) |
@Ngorror #109 koa-router vs @koa/router
|
- replace[key] = value.toString();
+ replace[key] = String(value); |
c37e557
to
1a2ff6c
Compare
@harryby1149 can you submit another PR that adds docs where necessary for |
v13.0.1 released https://github.com/koajs/router/releases/tag/v13.0.1 |
* chore: upgrade path-to-regex to v8.1.0 * chore: upgrade path-to-regex to v8.1.0 * chore: clean up test syntax * chore: clean up whitespace changes * chore: use String constructor instead of .toString for type conversion
* chore: upgrade path-to-regex to v8.1.0 * chore: upgrade path-to-regex to v8.1.0 * chore: clean up test syntax * chore: clean up whitespace changes * chore: use String constructor instead of .toString for type conversion
Checklist
Kudos to @iambumblehead #188 . This Pull Request ups the version of path-to-regex dependency to latest. Updates options logic to pass new parsing option down to the layer object.