remove req.host= #278
Merged
remove req.host= #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| when `app.proxy` is __true__, otherwise `Host` is used. | ||
|
|
||
| ### req.host= | ||
|
|
||
| Set the `Host` header field to a new value. | ||
| Set the `Host` header field to a new value. Set the `X-Forwarded-Host` |
There was a problem hiding this comment.
maybe we should just get rid of .host=, I can't think of any reason it would ever be useful
There was a problem hiding this comment.
+1 for remove. it is weird
There was a problem hiding this comment.
oh weird. i never knew we even had .host=.
|
removed |
|
just as an aside with all this host stuff: expressjs/express#2099 any thoughts? https://github.com/expressjs/proxy-addr was just created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.