-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set layer media types consistently #776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #776 +/- ##
==========================================
+ Coverage 51.20% 51.30% +0.10%
==========================================
Files 44 44
Lines 3316 3329 +13
==========================================
+ Hits 1698 1708 +10
- Misses 1401 1403 +2
- Partials 217 218 +1
|
jonjohnsonjr
approved these changes
Jul 21, 2022
Closed
khrm
added a commit
to tektoncd/triggers
that referenced
this pull request
Sep 6, 2022
We updated ko to v0.12.0 so that media layers are set consistently. Reference issue: ko-build/ko#776
4 tasks
tekton-robot
pushed a commit
to tektoncd/triggers
that referenced
this pull request
Sep 6, 2022
We updated ko to v0.12.0 so that media layers are set consistently. Reference issue: ko-build/ko#776
khrm
added a commit
to khrm/pipeline
that referenced
this pull request
Sep 22, 2022
This ko version fixes ko-build/ko#776 which should resolve tektoncd#5188
7 tasks
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Sep 23, 2022
This ko version fixes ko-build/ko#776 which should resolve #5188
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this pull request
Sep 28, 2022
This ko version fixes ko-build/ko#776 which should resolve tektoncd#5188
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Sep 28, 2022
This ko version fixes ko-build/ko#776 which should resolve #5188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently always append layers with Docker media types, even if the base image is an OCI image (e.g., our new default base image,
ghcr.io/distroless/static
)This works fine against some registries (GCR), but not against others (apparently Quay, Gitlab Registry, probably others).
This was reported in tektoncd/pipeline#5188 since Tekton switched its base image for git-init to ghcr.io/distroless/git
This changes our layer creation to check for the type of the base image, and set layer media types accordingly.