Use tools/go/packages in place of go/build #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmoss
commented
Oct 21, 2021
| @@ -222,7 +200,7 @@ func TestGoBuildIsSupportedRefWithModules(t *testing.T) { | |||
| for _, importpath := range []string{ | |||
| "ko://github.com/google/ko/pkg/build", // not a command. | |||
| "ko://github.com/google/ko/pkg/nonexistent", // does not exist. | |||
| "ko://github.com/google/ko", // not in this module. | |||
| "ko://github.com/google/go-github", // not in this module. | |||
There was a problem hiding this comment.
Not really sure about this, we're not mocking the module anymore and so ko://github.com/google/ko is buildable
Codecov Report
@@ Coverage Diff @@
## main #486 +/- ##
==========================================
- Coverage 53.11% 52.35% -0.76%
==========================================
Files 36 36
Lines 1847 1801 -46
==========================================
- Hits 981 943 -38
+ Misses 715 710 -5
+ Partials 151 148 -3
Continue to review full report at Codecov.
|
benmoss
force-pushed
the
go-builder-packages
branch
from
9de1e1c
to
eb3e456
Compare
imjasonh
previously approved these changes
Oct 22, 2021
Signed-off-by: Ben Moss <[email protected]>
halvards
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305
Turned out to be easier than I thought, assuming I understand anything 😸