Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to customize publish.Namer #477

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Oct 13, 2021

Fixes #476

  • Adds ability to pass custom publish.Namer
  • Adds ability to override default path separator, allowing use with container registries that don't allow nested repositories (Quay, Docker Hub etc.)

@jonjohnsonjr
Copy link
Collaborator

Exposing this as an option seems fine, but I'm less excited about another flag for this... want to split this into 2 PRs so we can land the namer change?

@cardil
Copy link
Contributor Author

cardil commented Dec 8, 2021

Okay. That seems reasonable to me. I would only need the code change, as I'm embedding ko in my build tools, so I think I'll just drop the flag out in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #477 (bd14330) into main (6447264) will decrease coverage by 4.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   53.13%   48.81%   -4.33%     
==========================================
  Files          36       42       +6     
  Lines        1848     2188     +340     
==========================================
+ Hits          982     1068      +86     
- Misses        715      942     +227     
- Partials      151      178      +27     
Impacted Files Coverage Δ
pkg/commands/options/publish.go 42.85% <100.00%> (ø)
pkg/publish/default.go 56.86% <0.00%> (-4.98%) ⬇️
pkg/commands/commands.go 72.72% <0.00%> (-2.28%) ⬇️
pkg/commands/deps.go 15.18% <0.00%> (-2.06%) ⬇️
pkg/build/gobuild.go 56.61% <0.00%> (-1.83%) ⬇️
pkg/commands/resolver.go 31.88% <0.00%> (-0.63%) ⬇️
pkg/commands/config.go 57.37% <0.00%> (-0.15%) ⬇️
pkg/build/limit.go 55.55% <0.00%> (ø)
pkg/build/strict.go 100.00% <0.00%> (ø)
pkg/commands/apply.go 51.35% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6447264...bd14330. Read the comment docs.

@cardil cardil requested a review from jonjohnsonjr December 14, 2021 18:24
@cardil cardil force-pushed the feature/configurable-namer branch from c69fcb0 to ed38fa6 Compare December 14, 2021 20:02
@cardil cardil force-pushed the feature/configurable-namer branch from ed38fa6 to bd14330 Compare December 14, 2021 20:04
@cardil cardil requested a review from jonjohnsonjr December 14, 2021 20:05
@jonjohnsonjr
Copy link
Collaborator

Thanks!

@jonjohnsonjr jonjohnsonjr merged commit 84e8ab6 into ko-build:main Dec 14, 2021
@cardil cardil deleted the feature/configurable-namer branch December 14, 2021 21:50
cardil added a commit to wavesoftware/go-magetasks that referenced this pull request Dec 15, 2021
cardil added a commit to wavesoftware/go-magetasks that referenced this pull request Dec 15, 2021
* Apply changes for ko-build/ko#476

This reverts commit 6b07449.

* Adjusting code to  outcome of ko-build/ko#477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to customize publish.Namer
3 participants