-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to customize publish.Namer
#477
Allow to customize publish.Namer
#477
Conversation
Exposing this as an option seems fine, but I'm less excited about another flag for this... want to split this into 2 PRs so we can land the namer change? |
Okay. That seems reasonable to me. I would only need the code change, as I'm embedding ko in my build tools, so I think I'll just drop the flag out in this PR. |
Codecov Report
@@ Coverage Diff @@
## main #477 +/- ##
==========================================
- Coverage 53.13% 48.81% -4.33%
==========================================
Files 36 42 +6
Lines 1848 2188 +340
==========================================
+ Hits 982 1068 +86
- Misses 715 942 +227
- Partials 151 178 +27
Continue to review full report at Codecov.
|
c69fcb0
to
ed38fa6
Compare
ed38fa6
to
bd14330
Compare
Thanks! |
* Apply changes for ko-build/ko#476 This reverts commit 6b07449. * Adjusting code to outcome of ko-build/ko#477
Fixes #476
publish.Namer