-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always produce OCI images and indexes #449
Conversation
My only reluctance here is breaking folks that push to old registries that won't support OCI. I guess they could just use an old version of |
Yeah... we could have an |
I'd be ok with deferring this until someone complains. |
Codecov Report
@@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 53.25% 53.26%
=======================================
Files 36 36
Lines 1842 1838 -4
=======================================
- Hits 981 979 -2
+ Misses 710 709 -1
+ Partials 151 150 -1
Continue to review full report at Codecov.
|
This reverts commit 465eca2. This breaks pushing to quay.io.
Followup from #354
Before this change, if the base image was a Docker manifest list, it could not be annotated with base image information. With this change,
ko
always produces OCI images and indexes, which can be annotated.Verified manually as well: