feat: Add template params for git #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmittler
force-pushed
the
git-params
branch
2 times, most recently
from
aa9d11d to
2cd8f0e
Compare
|
It seems that the vendoring is causing issues with including dependencies like testify. I've reverted the mod/vendor changes in favor of just hand-rolling |
nmittler
changed the title
nmittler
force-pushed
the
git-params
branch
5 times, most recently
from
bd46af2 to
9f0d938
Compare
imjasonh
reviewed
May 15, 2024
imjasonh
reviewed
May 15, 2024
There was a problem hiding this comment.
Copying Slack thread comment for posterity:
Do you intend to use all of these template features? I'm a little wary of speculatively adding features that we don't intend to use and get value from. If it's to keep compatibility with goreleaser I can understand, but that's also a moving target. 😕
I don't tend to use the goreleaser features myself to be honest, so I may be especially biased against this. If you or others do get value from that though I'm happy to approve.
nmittler
force-pushed
the
git-params
branch
2 times, most recently
from
b4a678f to
eda6b0d
Compare
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes ko-build#493 Signed-off-by: Nathan Mittler <[email protected]>
imjasonh
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a number of template parameters supported by goreleaser. Specifically, the build date information and the majority of the Git params.
Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files.
Fixes #493