update missing places that was using go1.20 #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cpanato <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
=======================================
Coverage 49.34% 49.34%
=======================================
Files 44 44
Lines 3640 3640
=======================================
Hits 1796 1796
Misses 1614 1614
Partials 230 230 ☔ View full report in Codecov by Sentry. |
imjasonh
reviewed
Oct 11, 2023
.github/workflows/e2e.yaml
Outdated
| @@ -21,7 +21,7 @@ jobs: | |||
| - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | |||
| - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 | |||
| with: | |||
| go-version: '1.20' | |||
| go-version: '1.21' | |||
There was a problem hiding this comment.
Suggested change
| go-version: '1.21' | |
| go-version-file: 'go.mod' |
This keeps it up to date as we update go.mod, and prevents future update PRs like this.
.goreleaser.yml
Outdated
| @@ -30,7 +30,7 @@ kos: | |||
| - id: ko-image | |||
| build: binary | |||
| main: . | |||
| base_image: golang:1.20 | |||
| base_image: golang:1.21 | |||
There was a problem hiding this comment.
Suggested change
| base_image: golang:1.21 | |
| base_image: golang:latest |
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
imjasonh
previously approved these changes
Oct 11, 2023
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
imjasonh
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.