Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop binary and image name w/ v2+ modules (#1091) #1152

Closed
wants to merge 1 commit into from

Conversation

tgrennan
Copy link

I've done very little testing but I think this may fix issue #1091
% ./hack/presubmit.sh
~/github.com/ko-build/ko ~/github.com/ko-build/ko
~/github.com/ko-build/ko

@cpanato cpanato requested a review from imjasonh September 15, 2023 06:54
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 60.00% and no project coverage change.

Comparison is base (cf3e626) 49.34% compared to head (d4e3cdd) 49.34%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1152   +/-   ##
=======================================
  Coverage   49.34%   49.34%           
=======================================
  Files          44       44           
  Lines        3640     3646    +6     
=======================================
+ Hits         1796     1799    +3     
- Misses       1614     1616    +2     
- Partials      230      231    +1     
Files Changed Coverage Δ
pkg/build/gobuild.go 57.30% <50.00%> (ø)
pkg/build/strict.go 85.00% <50.00%> (-15.00%) ⬇️
pkg/commands/options/publish.go 40.38% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants