Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update boilerplate file to be KO Build Authors #1056

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 24, 2023

Fixes: #1040

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #1056 (e47517c) into main (ccc0627) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   52.82%   52.82%           
=======================================
  Files          43       43           
  Lines        3360     3360           
=======================================
  Hits         1775     1775           
  Misses       1359     1359           
  Partials      226      226           
Impacted Files Coverage Δ
pkg/build/cache.go 42.46% <ø> (ø)
pkg/build/config.go 0.00% <ø> (ø)
pkg/build/future.go 100.00% <ø> (ø)
pkg/build/gobuild.go 57.29% <ø> (ø)
pkg/build/gobuilds.go 73.07% <ø> (ø)
pkg/build/layer.go 0.00% <ø> (ø)
pkg/build/limit.go 56.25% <ø> (ø)
pkg/build/options.go 64.70% <ø> (ø)
pkg/build/recorder.go 81.81% <ø> (ø)
pkg/build/shared.go 93.54% <ø> (ø)
... and 33 more

@cpanato cpanato force-pushed the update-boilerplate branch from b6606d0 to fbc9f3a Compare May 24, 2023 13:23
Signed-off-by: cpanato <[email protected]>
@cpanato cpanato force-pushed the update-boilerplate branch 2 times, most recently from 137751f to 53a1ec5 Compare May 24, 2023 13:38
@cpanato
Copy link
Member Author

cpanato commented May 24, 2023

cc @imjasonh

developer-guy
developer-guy previously approved these changes May 24, 2023
@@ -1,4 +1,4 @@
// Copyright 2021 Google LLC All Rights Reserved.
// Copyright 2021 ko Build Authors All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to keep moving the target. I think this should be Copyright 20XX ko Authors All Rights Reserved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot change that :/ the job check fails then

Error: [Go headers] reported by reviewdog 🐶
  missing boilerplate:
  
  Raw Output:
  main.go:1: missing boilerplate:
  // Copyright 20XX ko Build Authors All Rights Reserved.
  //
  // Licensed under the Apache License

@cpanato cpanato force-pushed the update-boilerplate branch from c3a5fe3 to 7bcfcaf Compare May 26, 2023 06:53
@cpanato cpanato force-pushed the update-boilerplate branch from 7bcfcaf to 64e11c3 Compare May 26, 2023 06:57
@cpanato cpanato requested a review from imjasonh May 26, 2023 07:04
@imjasonh imjasonh merged commit 2b8ee98 into ko-build:main Jun 9, 2023
@cpanato cpanato deleted the update-boilerplate branch June 9, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Who should own the Copyright of new code?
4 participants