Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --local with KO_DOCKER_REPO #1017

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Fix --local with KO_DOCKER_REPO #1017

merged 1 commit into from
Apr 22, 2023

Conversation

jonjohnsonjr
Copy link
Collaborator

#820 might have been a regression?

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #1017 (df0243a) into main (ba63655) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   52.80%   52.80%           
=======================================
  Files          43       43           
  Lines        3348     3348           
=======================================
  Hits         1768     1768           
  Misses       1355     1355           
  Partials      225      225           
Impacted Files Coverage Δ
pkg/commands/resolver.go 36.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonjohnsonjr jonjohnsonjr changed the title Maybe fix --local Fix --local with KO_DOCKER_REPO Apr 21, 2023
@jonjohnsonjr jonjohnsonjr requested a review from imjasonh April 21, 2023 22:29
@imjasonh imjasonh merged commit 6284661 into ko-build:main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants