-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ko is unable to push to a registry with a host and port number #93
Comments
The root of the issue is that A naive patch would be to append a fake path on the base before validating the repo base, however, this may cause issues with Docker Hub hosted repositories which may only contain a single slash. |
This allows you to use e.g. localhost:5000 as KO_DOCKER_REPO. Fixes ko-build#93.
This allows you to use e.g. localhost:5000 as KO_DOCKER_REPO. Fixes #93.
@jonjohnsonjr thanks for the quick turn around |
You were the lucky third person to complain about this, so I decided maybe I'm the one that's wrong :P cc @ian-mi this should be fixed now |
The fix for this broke dockerhub defaulting: #90 (comment) Going to reopen this to track that. I think we can fix this by just re-ordering how we parse things. Basically we just need to make sure:
|
I have got familiar with code looking on the other one. I will create PR for it, if you don't mind. Seems like re-ordering would do the trick, but will double check. |
Fixes ko-build#93 With this change we support also pointing to default registry (without prefix). Eg. KO_DOCKER_REPO=myuser
Fixes #93 With this change we support also pointing to default registry (without prefix). Eg. KO_DOCKER_REPO=myuser
When attempting to push images to a registry that uses a hostname and port (like
registry.kube-system.svc.cluster.local:5000
),ko
fails with the following error:A hostname and port is a valid registry and should be accepted by
ko
The text was updated successfully, but these errors were encountered: