Improve errors/warnings for unnecessary .ko.yaml settings #542
Labels
good first issue
Good for newcomers
Comments
|
Another one:
|
|
For all of these I think we should log a warning, and note that they might become failures in a future release. Then, after we cut a release (v0.10), we can make them failures. |
|
Another:
|
Closed
halvards
added a commit
to halvards/ko
that referenced
this issue
Jan 25, 2022
This change adds a dependency on `go-logr/logr` and replaces all uses of
the `log` package from Go's standard library with a `logr`-based
implementation.
To ease the transition, and to keep the diff small, this change
introduces a package `github.com/google/ko/pkg/log` that should be
imported in place of `log` from the standard library.
The new package provides some of the same functions as `log`, e.g.,
`Printf()` and `Fatalf()`. The replacement functions takes an extra
`context.Context` argument. The `Context` is used to look up the
`logr.Logger` to use for logging.
Existing log statements have been updated to use the transition
functions, with `Context` plumbed through where required.
New code can use the new logging syntax, e.g.:
```go
log.L(ctx).Info("something interesting happened", "key", "value")
```
or
```go
log.L(ctx).Error(err, "uh oh", "what", "snafu")
```
This change alters the log output to `logr`'s structured output, with
named fields for the log message and level. As an example, a log line
that previously looked like this:
```
2022/01/25 19:44:18 Building github.com/google/ko/test for linux/amd64
```
Will look like as follows with this change:
```
2022/01/25 19:46:02 ko: "level"=1 "msg"="Building github.com/google/ko/test for linux/amd64"
```
Fixes: ko-build#560
Related: ko-build#542
halvards
added a commit
to halvards/ko
that referenced
this issue
Jan 25, 2022
This change adds a dependency on `go-logr/logr` and replaces all uses of
the `log` package from Go's standard library with a `logr`-based
implementation.
To ease the transition, and to keep the diff small, this change
introduces a package `github.com/google/ko/pkg/log` that should be
imported in place of `log` from the standard library.
The new package provides some of the same functions as `log`, e.g.,
`Printf()` and `Fatalf()`. The replacement functions takes an extra
`context.Context` argument. The `Context` is used to look up the
`logr.Logger` to use for logging.
Existing log statements have been updated to use the transition
functions, with `Context` plumbed through where required.
New code can use the new logging syntax, e.g.:
```go
log.L(ctx).Info("something interesting happened", "key", "value")
```
or
```go
log.L(ctx).Error(err, "uh oh", "what", "snafu")
```
This change alters the log output to `logr`'s structured output, with
named fields for the log message and level. As an example, a log line
that previously looked like this:
```
2022/01/25 19:44:18 Building github.com/google/ko/test for linux/amd64
```
Will look like as follows with this change:
```
2022/01/25 19:46:02 ko: "level"=1 "msg"="Building github.com/google/ko/test for linux/amd64"
```
Fixes: ko-build#560
Related: ko-build#542
halvards
added a commit
to halvards/ko
that referenced
this issue
Jan 25, 2022
This change adds a dependency on `go-logr/logr` and replaces all uses of
the `log` package from Go's standard library with a `logr`-based
implementation.
To ease the transition, and to keep the diff small, this change
introduces a package `github.com/google/ko/pkg/log` that should be
imported in place of `log` from the standard library.
The new package provides some of the same functions as `log`, e.g.,
`Printf()` and `Fatalf()`. The replacement functions takes an extra
`context.Context` argument. The `Context` is used to look up the
`logr.Logger` to use for logging.
Existing log statements have been updated to use the transition
functions, with `Context` plumbed through where required.
New code can use the new logging syntax, e.g.:
```go
log.L(ctx).Info("something interesting happened", "key", "value")
```
or
```go
log.L(ctx).Error(err, "uh oh", "what", "snafu")
```
This change alters the log output to `logr`'s structured output, with
named fields for the log message and level. As an example, a log line
that previously looked like this:
```
2022/01/25 19:44:18 Building github.com/google/ko/test for linux/amd64
```
Will look like as follows with this change:
```
2022/01/25 19:46:02 ko: "level"=1 "msg"="Building github.com/google/ko/test for linux/amd64"
```
Fixes: ko-build#560
Related: ko-build#542
halvards
added a commit
to halvards/ko
that referenced
this issue
Jan 25, 2022
This change adds a dependency on `go-logr/logr` and replaces all uses of
the `log` package from Go's standard library with a `logr`-based
implementation.
To ease the transition, and to keep the diff small, this change
introduces a package `github.com/google/ko/pkg/log` that should be
imported in place of `log` from the standard library.
The new package provides some of the same functions as `log`, e.g.,
`Printf()` and `Fatalf()`. The replacement functions takes an extra
`context.Context` argument. The `Context` is used to look up the
`logr.Logger` to use for logging.
Existing log statements have been updated to use the transition
functions, with `Context` plumbed through where required.
New code can use the new logging syntax, e.g.:
```go
log.L(ctx).Info("something interesting happened", "key", "value")
```
or
```go
log.L(ctx).Error(err, "uh oh", "what", "snafu")
```
This change alters the log output to `logr`'s structured output, with
named fields for the log message and level. As an example, a log line
that previously looked like this:
```
2022/01/25 19:44:18 Building github.com/google/ko/test for linux/amd64
```
Will look like as follows with this change:
```
2022/01/25 19:46:02 ko: "level"=1 "msg"="Building github.com/google/ko/test for linux/amd64"
```
Fixes: ko-build#560
Related: ko-build#542
This was referenced Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From #530 (comment)
Each of these could be warnings or errors to help make
.ko.yamleasier to use and less needlessly verbose.The text was updated successfully, but these errors were encountered: