Merge pull request #17 from ImJasonH/weak

Drop name.WeakValidation

pkg/publish/daemon.go

@@ -50,7 +50,7 @@ func (d *demon) Publish(img v1.Image, s string) (name.Reference, error) {
 		return nil, err
 	}
 
-	digestTag, err := name.NewTag(fmt.Sprintf("%s/%s:%s", LocalDomain, d.namer(s), h.Hex), name.WeakValidation)
+	digestTag, err := name.NewTag(fmt.Sprintf("%s/%s:%s", LocalDomain, d.namer(s), h.Hex))
 	if err != nil {
 		return nil, err
 	}
@@ -63,7 +63,7 @@ func (d *demon) Publish(img v1.Image, s string) (name.Reference, error) {
 
 	for _, tagName := range d.tags {
 		log.Printf("Adding tag %v", tagName)
-		tag, err := name.NewTag(fmt.Sprintf("%s/%s:%s", LocalDomain, d.namer(s), tagName), name.WeakValidation)
+		tag, err := name.NewTag(fmt.Sprintf("%s/%s:%s", LocalDomain, d.namer(s), tagName))
 		if err != nil {
 			return nil, err
 		}

pkg/publish/default.go

@@ -95,7 +95,7 @@ func (d *defalt) Publish(img v1.Image, s string) (name.Reference, error) {
 	s = strings.ToLower(s)
 
 	for _, tagName := range d.tags {
-		tag, err := name.NewTag(fmt.Sprintf("%s/%s:%s", d.base, d.namer(s), tagName), name.WeakValidation)
+		tag, err := name.NewTag(fmt.Sprintf("%s/%s:%s", d.base, d.namer(s), tagName))
 		if err != nil {
 			return nil, err
 		}
@@ -112,7 +112,7 @@ func (d *defalt) Publish(img v1.Image, s string) (name.Reference, error) {
 	if err != nil {
 		return nil, err
 	}
-	dig, err := name.NewDigest(fmt.Sprintf("%s/%s@%s", d.base, d.namer(s), h), name.WeakValidation)
+	dig, err := name.NewDigest(fmt.Sprintf("%s/%s@%s", d.base, d.namer(s), h))
 	if err != nil {
 		return nil, err
 	}

pkg/publish/default_test.go

@@ -67,7 +67,7 @@ func TestDefault(t *testing.T) {
 	if err != nil {
 		t.Fatalf("url.Parse(%v) = %v", server.URL, err)
 	}
-	tag, err := name.NewTag(fmt.Sprintf("%s/%s:latest", u.Host, expectedRepo), name.WeakValidation)
+	tag, err := name.NewTag(fmt.Sprintf("%s/%s:latest", u.Host, expectedRepo))
 	if err != nil {
 		t.Fatalf("NewTag() = %v", err)
 	}
@@ -130,7 +130,7 @@ func TestDefaultWithCustomNamer(t *testing.T) {
 	if err != nil {
 		t.Fatalf("url.Parse(%v) = %v", server.URL, err)
 	}
-	tag, err := name.NewTag(fmt.Sprintf("%s/%s:latest", u.Host, expectedRepo), name.WeakValidation)
+	tag, err := name.NewTag(fmt.Sprintf("%s/%s:latest", u.Host, expectedRepo))
 	if err != nil {
 		t.Fatalf("NewTag() = %v", err)
 	}
@@ -194,7 +194,7 @@ func TestDefaultWithTags(t *testing.T) {
 	if err != nil {
 		t.Fatalf("url.Parse(%v) = %v", server.URL, err)
 	}
-	tag, err := name.NewTag(fmt.Sprintf("%s/%s:notLatest", u.Host, expectedRepo), name.WeakValidation)
+	tag, err := name.NewTag(fmt.Sprintf("%s/%s:notLatest", u.Host, expectedRepo))
 	if err != nil {
 		t.Fatalf("NewTag() = %v", err)
 	}

pkg/publish/future_test.go

@@ -31,7 +31,7 @@ func makeRef() (name.Reference, error) {
 	if err != nil {
 		return nil, err
 	}
-	return name.NewDigest(fmt.Sprintf("gcr.io/foo/bar@%s", d), name.WeakValidation)
+	return name.NewDigest(fmt.Sprintf("gcr.io/foo/bar@%s", d))
 }
 
 func TestSameFutureSameReference(t *testing.T) {

pkg/publish/options.go

@@ -48,7 +48,7 @@ func WithAuthFromKeychain(keys authn.Keychain) Option {
 		// means that docker.io/mattmoor actually gets interpreted as
 		// docker.io/library/mattmoor, which gets tricky when we start
 		// appending things to it in the publisher.
-		repo, err := name.NewRepository(i.base, name.WeakValidation)
+		repo, err := name.NewRepository(i.base)
 		if err != nil {
 			return err
 		}

pkg/resolve/fixed_test.go

@@ -26,7 +26,7 @@ import (
 )
 
 var (
-	fixedBaseRepo, _ = name.NewRepository("gcr.io/asdf", name.WeakValidation)
+	fixedBaseRepo, _ = name.NewRepository("gcr.io/asdf")
 	testImage, _     = random.Image(1024, 5)
 )
 
@@ -129,7 +129,7 @@ func (f *fixedPublish) Publish(_ v1.Image, s string) (name.Reference, error) {
 	if !ok {
 		return nil, fmt.Errorf("unsupported importpath: %q", s)
 	}
-	d, err := name.NewDigest(fmt.Sprintf("%s/%s@%s", f.base, s, h), name.WeakValidation)
+	d, err := name.NewDigest(fmt.Sprintf("%s/%s@%s", f.base, s, h))
 	if err != nil {
 		return nil, err
 	}

pkg/resolve/resolve_test.go

@@ -316,7 +316,7 @@ func mustRandom() v1.Image {
 }
 
 func mustRepository(s string) name.Repository {
-	n, err := name.NewRepository(s, name.WeakValidation)
+	n, err := name.NewRepository(s)
 	if err != nil {
 		panic(err)
 	}