-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile warnings in src/c-libedit #24
Comments
I see that we already maintain a set of patches that |
I believe this will be fixed by #25. |
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this issue
Mar 10, 2023
98206: deps: update go-libedit r=rickystewart a=knz I am expecting this will be one of the last updates to go-libedit since we plan to replace it with bubbline for good. However, this imports a few patches and reduces build warnings, which folk find useful. xref knz/go-libedit#24 Release note: None Epic: None 98287: roachtest: mvcc_gc disable lease rebalancing for stability r=erikgrinaker a=aliher1911 Test sometimes flakes if lease is moved from under GC and cleanup is not performed in time. This commit disables rebalance as it is not required to test GC functionality. This commit also improves reliability of test by preventing a race between workload stop and table data deletion which could cause test to fail if workload doesn't terminate before clear range is performed. Release note: None Fixes #97340 Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Oleg Afanasyev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The warnings below show up during the lint tests in CockroachDB, distracting from the actual error messages. Could we modify the source to fix them? Adding some casts might fix them.
The text was updated successfully, but these errors were encountered: