fix infinite loop #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you give me an example to reproduce the issue? |
|
Sure
package main
import (
"log"
debver "github.com/knqyf263/go-deb-version"
)
func main() {
from := "1.12+git+1+e37ca00-0.3"
to := "1.12+git+1+e37ca0"
verFrom, err := debver.NewVersion(from)
if err != nil {
log.Fatal(err)
}
verTo, err := debver.NewVersion(to)
if err != nil {
log.Fatalln(err)
}
result := verFrom.Compare(verTo)
log.Println(result)
}
…On Thu, Mar 10, 2022 at 5:44 PM Teppei Fukuda ***@***.***> wrote:
Could you give me an example to reproduce the issue?
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEWFI56KREJQ5QJKKVQSODDU7IKEFANCNFSM5QC6NDQQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Regards,
Ionut Andriescu
|
knqyf263
reviewed
Feb 23, 2023
Comment on lines
+201
to
+220
| var index int | ||
| c1 := len(strings1) | ||
| c2 := len(strings2) | ||
| if c1 >= c2 { | ||
| index = c1 | ||
| } else { | ||
| index = c2 | ||
| } |
There was a problem hiding this comment.
What if comparing numbers1 with numbers2, and strings1 with strings2?
Suggested change
| var index int | |
| c1 := len(strings1) | |
| c2 := len(strings2) | |
| if c1 >= c2 { | |
| index = c1 | |
| } else { | |
| index = c2 | |
| } | |
| if reflect.DeepEqual(numbers1, numbers2) && reflect.DeepEqual(strings1, strings2) { | |
| return 0 | |
| } |
Comment on lines
+232
to
+253
| var index int | ||
| c1 := len(s1) | ||
| c2 := len(s2) | ||
| if c1 >= c2 { | ||
| index = c1 | ||
| } else { | ||
| index = c2 | ||
| } | ||
|
|
||
| for i := 0; i < index; i++ { |
There was a problem hiding this comment.
Are you sure we need them? if s1 == s2 {} prevents infinite loops, I think.
|
Hi @knqyf263 |
Signed-off-by: knqyf263 <[email protected]>
knqyf263
approved these changes
Nov 15, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.