Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception (unreachable code) when forgetting '?' in rule body #500

Closed
ellmau opened this issue Jul 4, 2024 · 0 comments · Fixed by #501
Closed

Exception (unreachable code) when forgetting '?' in rule body #500

ellmau opened this issue Jul 4, 2024 · 0 comments · Fixed by #501
Labels
bug Something isn't working
Milestone
Release 0.6.0

Comments

@ellmau
Copy link
Member

ellmau commented Jul 4, 2024

Assume a small example:

eq(?a) :- pair(?a,?b), ?a = ?b.

This runs and performs as intended, by introducing two typing mistakes into the rule, we will get an exception instead of an error message:

eq(?a) :- pair(?a,?b), a = b.

error_msg.txt

The current version is 0.5.2-dev (ca5ddd6), using rustc v1.80.0-nightly (see corresponding flake file)
@ellmau ellmau added the bug Something isn't working label Jul 4, 2024
@mmarx mmarx added this to nemo Jul 4, 2024
@github-project-automation github-project-automation bot moved this to Todo in nemo Jul 4, 2024
@mmarx mmarx added this to the Release 0.6.0 milestone Jul 4, 2024
@aannleax aannleax mentioned this issue Jul 4, 2024
Merged
aannleax added a commit that referenced this issue Jul 10, 2024
@aannleax
Bug/500 constant filters (#501)
f55fe02 
I had code that computed the column on which a filter is going to be
applied on. This depended upon the input variables, e.g. when computing
`a(x, y, z), 2 * x > z`, the less-than filter should be applied on
column `z` as the value for `x` has to be bound when computing the
filter. The code that finds the last occurrence of a variable panicked
if the filter did not contain any variable.

To fix this I simply assign constant filters to the first column.

Fixes #500.
@github-project-automation github-project-automation bot moved this from Todo to Done in nemo Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
nemo
Archived in project
Milestone
Release 0.6.0
Development

Successfully merging a pull request may close this issue.

Bug/500 constant filters knowsys/nemo
2 participants
@mmarx @ellmau