Feature/609 ny startside med info fra browseit mm #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Har lagt inn alt jeg kommer på av nyttige lenker uten å tenke på kategorisering og styling, for å ha noe å teste med.
Laster inn lenkene fra egne Markdown. På sikt skal disse bo et sted de kan oppdateres uten å måtte prodsette Folk
karo
commented
Oct 9, 2024
| @@ -1,9 +1,10 @@ | |||
| export { default as CompetencePage } from './competence/CompetencePage' | |||
| export { default as CustomerPage } from './customer/CustomerPage' | |||
| export { default as CustomerSitePage } from './customer/CustomerSitePage' | |||
| export { default as DebugPage } from './other/DebugPage' | |||
There was a problem hiding this comment.
Flyttet så de ligger alfabetisk
karo
commented
Oct 9, 2024
| const [otherMD, setOtherMD] = useState('') | ||
|
|
||
| useEffect(() => { | ||
| fetch('/markdown/Administration.md') |
There was a problem hiding this comment.
Vi bør etterhvert få henta .md filene fra et annet sted, sånn at de kan oppdateres uten å ha github kompetanse
rauboti
reviewed
Oct 15, 2024
| @@ -22,7 +22,7 @@ export default function LoginLogoutButton() { | |||
| }, | |||
| }) | |||
|
|
|||
| navigate('/ansatte', { replace: true }) | |||
| navigate('/start', { replace: true }) | |||
There was a problem hiding this comment.
Kunne denne bare gått til '/' (sida den uansett forwarder til '/start'), så slipper vi flytte den på nytt dersom vi en dag skulle gjøre nye endringer på landingsside?
|
Uten at det er et hinder av noe slag; burde rekkefølga i markdown-filene vært hakket mer konsistent, slik at de er enklere å redigere? Tenker da på lenkene som er lista opp under. Burde de enten ha samme rekkefølge som overskriftene, eller (hvis ikke det) alfabetisk? |
rauboti
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#609