Small refactorings, performance enhancement and delicious button #73
Conversation
The clearfix didn't work well with bootstrap
Browser prefixes are handled by autoprefixer
Also remove delicious icon color
Add support for browser caching
|
Cool. We'll look this over. We definitely don't want to have to require Ruby or Node, but having grunt support is great. Thanks for contributing! |
Alt attributes are not supported on svg tags. Use role="img" aria- label="" instead.
|
Hi @dbox, Made an additional small change. Maybe we can take it with this pull request. |
|
Can you resolve the conflicts and resubmit? Thanks! |
|
Synced my |
|
Hi, Sorry for the late response. Good question. I don't think you can edit the Tried to goggle for "Illustrator import svg symbol" and also checked in the Illustrator's symbol panel but didn't find anything :-(. But there is hope. One could add Example below: This will allow You to preview the svg in Illustrator. I'm not sure what happens after you save it. |
|
It's also worth noting that using an svg spritesheet like this isn't supported in any version of Internet Explorer or Android 3.0 - 4.3 There is a polyfill for IE but not for Android. |
|
Also with regards to illustrator, would the correct workflow be: edit the individual svg's and use the grunt task to recreate the icons.svg spritesheet rather than editing it directly |
- Shiny new gulp/browser-sync dev environment /via @connorwyatt - Updated Facebook icon - New delicious icon - Added vk icon per #80 - fixed color for hackernews - Added delicious icon via @czerasz per #73 - Optimized code and inline svgs
|
Hi @czerasz. We decided to go with gulp instead of grunt, but I was able to add your delicious button. Pull down the latest and check it all out. I think this will be better fit your workflow now. Thanks again! |
|
Looks great. Well done! |
I added a
Gruntfile.jswhich makes development easier.It also adds support for autoprefixer and SVG sprites which enables browser caching.