Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email insta #188

Merged
merged 7 commits into from
Oct 12, 2016
Merged

Email insta #188

merged 7 commits into from
Oct 12, 2016

Conversation

dbox
Copy link
Contributor

@dbox dbox commented Oct 12, 2016

  • takes care of number new instagram logo #176
  • introduces a replacement icon for the mail icon. Previously it was an "@" symbol, but people have complained that it can be confused for Twitter. The original at-symbol can still be copied over from the icons folder if someone needs it. Screenshot here:
    image
  • updates all site references to http://rrssb.ml

@dbox dbox merged commit b47b24b into master Oct 12, 2016
@dbox dbox deleted the email-insta branch October 15, 2016 01:52
@dbox
Copy link
Contributor Author

dbox commented Oct 17, 2016

@gquemener fixed in 1.13.0. sorry about that!

@dbox
Copy link
Contributor Author

dbox commented Oct 17, 2016

Also I"m not sure how you could be seeing the buttons like that, regardless of the border appearing..

@gquemener
Copy link

gquemener commented Oct 18, 2016

Hello @dbox, I've just updated to 1.13.0 and the problem is still here. I'm importing the css file (in rrssb/css/rrssb.css) which still contains the border statement, something went wrong in your build process?

I'm not sure why the buttons are displayed like that also, I'm investigating.
Does the width of the buttons is calculated through javascript or is it a full-css behaviour?

@dbox
Copy link
Contributor Author

dbox commented Oct 18, 2016

Hello @dbox, I've just updated to 1.13.0 and the problem is still here. I'm importing the css file (in rrssb/css/rrssb.css) which still contains the border statement, something went wrong in your build process?

Looks like the minified css didn't get pushed. Try now please.

Does the width of the buttons is calculated through javascript or is it a full-css behaviour?

Both

@gquemener
Copy link

I think I understand.

The buttons are not present in the dom on first load (on document ready event), so I have to manually call the window.rrssbInit() function when I add them.

@gquemener
Copy link

Looks like the minified css didn't get pushed. Try now please.

Great, the border is not here anymore on 1.13.1.

Thanks for your lib 😉 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants