Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add correct interceptors usage #82

Merged
merged 2 commits into from
Apr 13, 2022
Merged

add correct interceptors usage #82

merged 2 commits into from
Apr 13, 2022

Conversation

yarilchenko
Copy link
Contributor

@yarilchenko yarilchenko commented Apr 13, 2022 •
edited
Loading

When using interceptors based on context (like using the class property in the interceptor) there was a problem.
PR should fix it

I've not added the same functionality for request interceptors because seems like it useless

@kingjan1999 kingjan1999 self-assigned this Apr 13, 2022
@yarilchenko
Copy link
Contributor Author

@kingjan1999 not sure about request interceptors. We are using axios-api-versioning package and seems it using interceptors to patch request config. I'll check and make updates or provide more info here

@kingjan1999 kingjan1999 merged commit 4d44dd7 into knee-cola:master Apr 13, 2022
@kingjan1999
Copy link
Collaborator

Thank you very much - merged!

@kingjan1999
Copy link
Collaborator

Published in 4.6.0

@yarilchenko
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kingjan1999 kingjan1999

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yarilchenko @kingjan1999