Deploy DomainMappings and Enable Alpha tests in e2e tests #9851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
do-not-merge/work-in-progress
knative-prow-robot
added
area/API
Codecov Report
@@ Coverage Diff @@
## master #9851 +/- ##
==========================================
- Coverage 87.76% 87.70% -0.06%
==========================================
Files 180 180
Lines 8596 8588 -8
==========================================
- Hits 7544 7532 -12
- Misses 803 806 +3
- Partials 249 250 +1
Continue to review full report at Codecov.
|
|
/retest |
knative-prow-robot
added
size/S
julz
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
/assign @mattmoor |
|
/test pull-knative-serving-istio-stable-no-mesh-tls |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9713.
Adds
--enable-alphaand--enable-beta(might as well) flags to e2e tests, and deploys DomainMappings.Once this lands we should be unblocked on landing #9780.