Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DomainMapping ConfigStore and allow configuring IngressClass #9796

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

julz
Copy link
Member

@julz julz commented Oct 13, 2020

Fifth part of #9713.

Respect the default ingressClass in network.yaml and allow overriding via annotation, analogously to Route.

/assign @mattmoor @dprotaso

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 13, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2020
@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Oct 13, 2020
@julz julz mentioned this pull request Oct 13, 2020
14 tasks
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #9796 into master will decrease coverage by 0.00%.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9796      +/-   ##
==========================================
- Coverage   87.76%   87.76%   -0.01%     
==========================================
  Files         180      181       +1     
  Lines        8552     8574      +22     
==========================================
+ Hits         7506     7525      +19     
- Misses        797      801       +4     
+ Partials      249      248       -1     
Impacted Files Coverage Δ
pkg/reconciler/domainmapping/controller.go 0.00% <0.00%> (ø)
pkg/reconciler/domainmapping/config/store.go 100.00% <100.00%> (ø)
pkg/reconciler/domainmapping/reconciler.go 85.36% <100.00%> (+0.36%) ⬆️
cmd/queue/main.go 0.51% <0.00%> (+0.51%) ⬆️
pkg/activator/net/revision_backends.go 91.40% <0.00%> (+0.90%) ⬆️
pkg/reconciler/revision/reconcile_resources.go 83.13% <0.00%> (+2.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a317c...fe2a2bc. Read the comment docs.

@julz
Copy link
Member Author

julz commented Oct 13, 2020

/retest

@mattmoor
Copy link
Member

/lgtm
/approve

Awesome 🤩

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
@knative-prow-robot knative-prow-robot merged commit 44b437b into knative:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants